fix: gate release branch PRs with team review, scope fallback to non-release#84
Merged
Merged
Conversation
…release Replace the blanket "no approval necessary" fallback with two scoped rules: - "release branch review": requires release-team approval for all PRs targeting release/* branches that don't match cherry-pick criteria - "non-release fallback": auto-approves PRs targeting non-release branches using RE2-compatible negation regex This ensures PRs with wrong titles or large diffs on release branches get PENDING status instead of being silently approved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jluque0101
approved these changes
Mar 5, 2026
omii2711
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the blanket
"no approval necessary"fallback (from PR #83) with two scoped rules so that PRs targetingrelease/*branches are properly gated.Rules
cherry-pick auto-approvalrelease/*+ cherry-pick title + < 200 LOCrelease branch reviewrelease/*(any PR)MetaMask/release-teamnon-release fallbackrelease/*The fallback uses a RE2-compatible negation regex since Go's regexp engine does not support lookaheads:
Evaluation scenarios
orresultrelease/*(< 200 LOC)mainrelease/*release/*Test plan
release/*with correct title and < 200 LOC →successmain→success(fallback rule)release/*without "cherry-pick" in title →pendingrelease/*→pending🤖 Generated with Claude Code